Remove remaining deprecated apis #12

NullVoxPopuli · 2022-10-11T21:51:05Z

Requires: #11

github-actions · 2022-10-11T21:55:13Z

Preview URLs

GH Env: preview
docs: https://6e5780de.ember-headless-table.pages.dev
api docs: https://6e5780de.ember-headless-table.pages.dev/api/modules.html

nicolechung · 2022-10-12T13:27:13Z

Unrelated, but already with the dark mode 🎉 !!

docs/plugins/row-selection/demo/demo-a.md

nicolechung · 2022-10-20T17:03:22Z

Preview URLs

GH Env: preview docs: https://b81f639d.ember-headless-table.pages.dev api docs: https://b81f639d.ember-headless-table.pages.dev/api/modules.html

It would be nice if this managed to update with new commits.

nicolechung · 2022-10-20T17:04:32Z

ember-headless-table/package.json

@@ -46,6 +47,9 @@
      "plugins/sticky-columns": [
        "./dist/plugins/sticky-columns/index.d.ts"
      ],
+      "plugins/row-selection": [


Is this something we manually have to add for each new plugin?

Maybe this should be a note in CONTRIBUTING

it's something that needs to be added in any package for any public entry point -- it's more "normal npm stuff", if that makes sense.
We probably should have a pointer to some doc talking about this tho.

nicolechung · 2022-10-20T17:10:17Z

test-app/tests/plugins/row-selection/rendering-test.gts

@@ -0,0 +1,312 @@
+import Component from '@glimmer/component';


Why the *.gts extension here? Is that this

Asking because I don't see other *.gts` files in the project, wondering if this is a new convention.

all the rendering tests use gts.

Is that this

nay, it's this: https://rfcs.emberjs.com/id/0779-first-class-component-templates

NullVoxPopuli · 2022-10-20T18:26:14Z

It would be nice if this managed to update with new commits.

it does, but Cloudflare doesn't run as fast as the tests.

…ualization

NullVoxPopuli · 2022-10-20T21:54:17Z

docs-app/package.json

-    "@glint/environment-ember-loose": "^0.9.5",
-    "@glint/environment-ember-template-imports": "^0.9.5",
-    "@glint/template": "^0.9.5",
+    "@glint/core": "^0.9.6",


this version fixes some bugs I was working around, so I just upgraded to it

NullVoxPopuli · 2022-10-20T21:54:28Z

docs/demos/index.md

@@ -0,0 +1,12 @@
+---
+categoryOrder: 3


we can now sort folders!

NullVoxPopuli · 2022-10-20T22:05:51Z

Finally green 🎉

nicolechung · 2022-10-21T13:27:47Z

I can't seem to run pnpm start locally (again). This is after deleting node_modules from all 5 packages, running pnpm install then pnpm build.

NullVoxPopuli · 2022-10-21T13:48:53Z

this is probably where turbo might be useful, we can force the build of the addon before starting the app.
Based on the error, it looks like the addon isn't built yet

nicolechung · 2022-10-21T13:56:00Z

this is probably where turbo might be useful, we can force the build of the addon before starting the app. Based on the error, it looks like the addon isn't built yet

But isn't this what pnpm build does? I ran this before pnpm start

It looks like docs-app is looking into node_modules for ember-headless-table which is in the...pnpm cache but that doesn't have a dist folder, but there is a dist folder in the ember-headless-table package / folder.

NullVoxPopuli · 2022-10-21T15:05:20Z

what version of pnpm are you using? I have 7.13.4, and just upgraded to 7.13.6

nicolechung · 2022-10-21T15:14:33Z

what version of pnpm are you using? I have 7.13.4, and just upgraded to 7.13.6

pnpm --version
7.5.0

Let me update

nicolechung · 2022-10-21T16:33:20Z

Tried again with

pnpm i
pnpm build
pnpm i
pnpm start

Works for me now.

danwenzel · 2022-10-21T20:16:37Z

docs/demos/lots-of-data-no-virtualization/demo/demo-a.md

+```hbs template
+
+FPS: {{this.fps}}<br>
+<div data-container class="h-full overflow-auto" {{this.table.modifiers.container}}>


come on, github. where's your syntax highlighting... :(

oh, the demo doesn't have it either:

yeah, I noticed that, too. but that's likely my fault.

GitHub requires that at least 200 repos use a new syntax before they add highlighting for it -- and I don't think they've ever supported nested highlighting in markdown without "rendering the file"

docs/demos/lots-of-data/index.md

danwenzel · 2022-10-21T20:30:55Z

test-app/tests/plugins/row-selection/rendering-test.gts

+
+import { headlessTable } from 'ember-headless-table';
+import { RowSelection, toggle, isSelected, select, deselect } from 'ember-headless-table/plugins/row-selection';
+import { DATA } from 'test-app/data';


Again with the lack of syntax highlighting here :(

This one's pretty funny, though:

oh! that is goofy!

danwenzel · 2022-10-21T20:33:08Z

test-app/tests/plugins/row-selection/rendering-test.gts

+      assert.expect(1);
+
+      setupOnerror((error) => {
+        let errorStr = error instanceof Error ? error.message : `${error}`;


nit: I usually prefer String(error) over ${error}

why's that?

I tend to go by https://eslint.org/docs/latest/rules/no-implicit-coercion

To me, it's more clear that you're intending to coerce to a string if you say String(...).

legit, is it available in Eslint 7?

Yup!

This rule was introduced in ESLint v1.0.0-rc-2.

danwenzel · 2022-10-21T20:34:39Z

test-app/tests/plugins/row-selection/rendering-test.gts

+      await click(rows[0]);
+
+      assert.strictEqual(ctx.selection.size, 0);
+      assert.deepEqual([...ctx.selection.values()], []);


With so many assertions here, would it help to add failure messages? Otherwise it may be hard to keep track of what's failed

maybe -- I didn't have any issue debugging this when I wrote it though -- the contents of expected and actual are printed in the browser -- so it's fairly easy to see what's going on, imo.
(obvs, if I get confused later, messages will get added 😅 )

Co-authored-by: Dan Wenzel <[email protected]>

github-actions · 2022-11-02T21:08:39Z

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Oct 16, 2022

Finish™ Docs #16

Merged

chore(cleanup): remove remaining deprecated APIs #24

Merged

NullVoxPopuli force-pushed the remove-remaining-deprecated-apis branch 4 times, most recently from 308f2b5 to 2911457 Compare October 18, 2022 22:12

NullVoxPopuli mentioned this pull request Oct 18, 2022

Introduce plugin signatures #39

Merged

NullVoxPopuli force-pushed the remove-remaining-deprecated-apis branch 2 times, most recently from 7f12f05 to 59487a3 Compare October 19, 2022 23:13

feat(plugin): implement row selection plugin

e46ce50

NullVoxPopuli force-pushed the remove-remaining-deprecated-apis branch from 59487a3 to e46ce50 Compare October 19, 2022 23:43

NullVoxPopuli added 3 commits October 20, 2022 10:43

chore(docs): update CONTRIBUTING.md about caveat related to pnpm bug

85ccaff

chore(row-selection): add tests

39439de

chore(docs): update docs for writing your own plugin

9438bfe

NullVoxPopuli requested review from ynotdraw, camskene, danwenzel and nicolechung October 20, 2022 15:31

chore(docs): add the ability to sort categories in the sidebar

01740a5

nicolechung reviewed Oct 20, 2022

View reviewed changes

docs/plugins/row-selection/demo/demo-a.md Show resolved Hide resolved

nicolechung reviewed Oct 20, 2022

View reviewed changes

chore(docs): add single-row-selection demo

0d6853e

NullVoxPopuli added 3 commits October 20, 2022 14:43

chore(docs): demonstrate lots of data with rapid updates without virt…

61a4b3e

…ualization

chore(docs): demonstrate lots of data with rapid updates without virt…

47caa83

…ualization

chore(types): try to fix types in test app

44c8c6a

chore(types): upgrade glint, fix types

8975658

NullVoxPopuli commented Oct 20, 2022

View reviewed changes

NullVoxPopuli marked this pull request as ready for review October 20, 2022 22:05

NullVoxPopuli requested a review from nicolechung October 20, 2022 22:09

This was referenced Oct 20, 2022

Simplify working with columns #40

Merged

Fix resizing column logic #41

Merged

danwenzel approved these changes Oct 21, 2022

View reviewed changes

chore(docs): fix spelling mistake

38c1d9f

Co-authored-by: Dan Wenzel <[email protected]>

nicolechung approved these changes Oct 21, 2022

View reviewed changes

NullVoxPopuli merged commit 6ba902f into main Oct 21, 2022

NullVoxPopuli deleted the remove-remaining-deprecated-apis branch October 21, 2022 22:12

github-actions bot added the released label Nov 2, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove remaining deprecated apis #12

Remove remaining deprecated apis #12

NullVoxPopuli commented Oct 11, 2022 •

edited

Loading

github-actions bot commented Oct 11, 2022 •

edited

Loading

nicolechung commented Oct 12, 2022

nicolechung commented Oct 20, 2022

Preview URLs

nicolechung Oct 20, 2022

NullVoxPopuli Oct 20, 2022

nicolechung Oct 20, 2022

NullVoxPopuli Oct 20, 2022

NullVoxPopuli commented Oct 20, 2022

NullVoxPopuli Oct 20, 2022

NullVoxPopuli Oct 20, 2022

NullVoxPopuli commented Oct 20, 2022

nicolechung commented Oct 21, 2022

NullVoxPopuli commented Oct 21, 2022

nicolechung commented Oct 21, 2022

NullVoxPopuli commented Oct 21, 2022

nicolechung commented Oct 21, 2022 •

edited

Loading

nicolechung commented Oct 21, 2022

danwenzel Oct 21, 2022

danwenzel Oct 21, 2022

NullVoxPopuli Oct 21, 2022

danwenzel Oct 21, 2022

NullVoxPopuli Oct 21, 2022

danwenzel Oct 21, 2022

NullVoxPopuli Oct 21, 2022

danwenzel Oct 21, 2022

NullVoxPopuli Oct 21, 2022

danwenzel Oct 21, 2022

danwenzel Oct 21, 2022

NullVoxPopuli Oct 21, 2022

github-actions bot commented Nov 2, 2022

		@@ -0,0 +1,312 @@
		import Component from '@glimmer/component';

		@@ -0,0 +1,12 @@
		---
		categoryOrder: 3

Remove remaining deprecated apis #12

Remove remaining deprecated apis #12

Conversation

NullVoxPopuli commented Oct 11, 2022 • edited Loading

github-actions bot commented Oct 11, 2022 • edited Loading

Preview URLs

nicolechung commented Oct 12, 2022

nicolechung commented Oct 20, 2022

Preview URLs

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

NullVoxPopuli commented Oct 20, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

NullVoxPopuli commented Oct 20, 2022

nicolechung commented Oct 21, 2022

NullVoxPopuli commented Oct 21, 2022

nicolechung commented Oct 21, 2022

NullVoxPopuli commented Oct 21, 2022

nicolechung commented Oct 21, 2022 • edited Loading

nicolechung commented Oct 21, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Nov 2, 2022

NullVoxPopuli commented Oct 11, 2022 •

edited

Loading

github-actions bot commented Oct 11, 2022 •

edited

Loading

nicolechung commented Oct 21, 2022 •

edited

Loading