Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add engines and volta fields to package.json #175

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

clintcs
Copy link
Contributor

@clintcs clintcs commented Jun 12, 2023

🚀 Description

The engines field of package.json is supported by PNPM and is thus version-manager independent. PNPM will fail if its version is out of range. See my code comment for why we should support a specific range.

Volta, meanwhile, is our preferred version manager. It will look to the volta field of package.json to determine which Node.js and PNPM versions to use.

Note that Volta's PNPM support is experimental and requires the environmental variable VOLTA_FEATURE_PNPM to be set to 1.

We should probably upgrade to a version 6.1 lock file and PNPM 8 as well, though I considered it out of scope. Happy to follow up with another PR if you'd like.

@changeset-bot
Copy link

changeset-bot bot commented Jun 12, 2023

⚠️ No Changeset found

Latest commit: 76f072e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jun 12, 2023

Preview URLs

Env: preview
Docs: https://93146382.ember-toucan-core.pages.dev

Copy link
Contributor

@ynotdraw ynotdraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably upgrade to a version 6.1 lock file and PNPM 8 as well, though I considered it out of scope.

Agreed on both points!

Happy to follow up with another PR if you'd like.

If you have the time, it'd be greatly appreciated!

@clintcs
Copy link
Contributor Author

clintcs commented Jun 12, 2023

If you have the time, it'd be greatly appreciated!

Will do!

@clintcs clintcs force-pushed the add-engines-field-to-package-json branch from 5429277 to 76f072e Compare June 13, 2023 17:09
@clintcs clintcs merged commit 76217a9 into main Jun 13, 2023
@clintcs clintcs deleted the add-engines-field-to-package-json branch June 13, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pnpm-lock.yaml incompatible with PNPM 7
2 participants