Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for running KAC on hostNetwork #327

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

TomRyan-321
Copy link
Contributor

@TomRyan-321 TomRyan-321 commented Oct 18, 2024

This PR introduces support for running KAC on hostNetwork and setting of dnsPolicy which is needed when some scenarios such as when custom CNI's are in use and control plane nodes are not be able to initiate network connections to pods.

Additionally this change adds support for configuring the watcher port and fixes missing webhookPort from being passed to the container client.

Copy link
Contributor

@pflanagan-cs pflanagan-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@redhatrises
Copy link
Contributor

Please rebase and drop commit fb9aaa8 as it messes with Git history.

@gpontejos
Copy link
Collaborator

Please remove the appVersion and version bump. There will be additional changes added to the release.

@TomRyan-321 TomRyan-321 force-pushed the falcon-kac/hostNetwork branch 8 times, most recently from 0dd87c1 to dbc1e37 Compare October 21, 2024 23:09
@TomRyan-321
Copy link
Contributor Author

rebased and removed version bump

@TomRyan-321 TomRyan-321 force-pushed the falcon-kac/hostNetwork branch 7 times, most recently from dbc1e37 to 7359b08 Compare January 17, 2025 05:55
@TomRyan-321
Copy link
Contributor Author

rebased to main

@TomRyan-321 TomRyan-321 force-pushed the falcon-kac/hostNetwork branch 4 times, most recently from af68e31 to 5c61ad7 Compare January 17, 2025 15:48
@TomRyan-321 TomRyan-321 force-pushed the falcon-kac/hostNetwork branch from 5c61ad7 to 8922193 Compare January 17, 2025 15:52
@redhatrises redhatrises merged commit 549ff6e into CrowdStrike:main Jan 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants