Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support flagged describe #284

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: support flagged describe #284

wants to merge 1 commit into from

Conversation

NullVoxPopuli
Copy link

@NullVoxPopuli NullVoxPopuli commented Apr 23, 2020 •
edited
Loading

as a todo, I still need to test if this works

@NullVoxPopuli NullVoxPopuli force-pushed the flagged-describe branch 2 times, most recently from d5a2ee1 to efbcf27 Compare April 24, 2020 20:15
@NullVoxPopuli
Copy link
Author

looks like lint:git is failing on commits that precede my own.

kellyselden
kellyselden requested changes May 13, 2020
View reviewed changes
Copy link
Collaborator

@kellyselden kellyselden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens when a describe has flags and an inner it has additional flags?

packages/mocha/src/flag.js Outdated Show resolved Hide resolved
packages/mocha/src/flag.js Outdated Show resolved Hide resolved
packages/mocha/src/flag.js Show resolved Hide resolved
packages/mocha/src/flag.js Show resolved Hide resolved
packages/mocha/src/index.js Outdated Show resolved Hide resolved
kellyselden
kellyselden requested changes Jun 15, 2020
View reviewed changes
Copy link
Collaborator

@kellyselden kellyselden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still needs tests? To see how it is used and if it works.

packages/mocha/src/index.js Outdated Show resolved Hide resolved
packages/mocha/src/flag.js Outdated Show resolved Hide resolved
packages/mocha/src/flag.js Outdated Show resolved Hide resolved
packages/mocha/src/flag.js Outdated Show resolved Hide resolved
packages/mocha/src/flag.js Outdated Show resolved Hide resolved
NullVoxPopuli added a commit to NullVoxPopuli/faltest that referenced this pull request Aug 14, 2020
@NullVoxPopuli
chore(internal): apply pr feedback on CrowdStrike#284
2333a91
@victormejia victormejia mentioned this pull request Feb 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kellyselden kellyselden kellyselden requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NullVoxPopuli @kellyselden