feat: add zip file func to simplify working with gzip encoding #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsteenb2
commented
Jun 14, 2024
file.go
Outdated
| } | ||
|
|
||
| // FileGZip writes the | ||
| func FileGZip(filename, contentType string, contents io.ReadCloser) File { |
There was a problem hiding this comment.
heh this will probably be the first thing I use writing my next fn... just too easy to pass up 🙃
jsteenb2
commented
Jun 14, 2024
|
|
||
| wantFilename := filepath.Join(tmp, "third_file.json") | ||
| equalVals(t, wantFilename, got.Filename) | ||
| equalGzipFiles(t, got.Filename, `{"dodgers":"reallystank"}`) |
jsteenb2
commented
Jun 14, 2024
| func (c *compressorGZIP) compressInput() { | ||
| defer func() { | ||
| c.gwClosed, c.pwClosed = true, true | ||
| err := c.pw.CloseWithError(c.gw.Close()) |
There was a problem hiding this comment.
order of operations here is very important, gzip writer has to close first, or it isn't able to write the final bits it writes on Close, rendering the entire gzip defunct
jsteenb2
force-pushed
the
feat/add_gzip_file
branch
2 times, most recently
from
e57c4f7 to
bcab699
Compare
jsteenb2
force-pushed
the
feat/add_gzip_file
branch
from
bcab699 to
3841319
Compare
johns31459
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also changes the File.Contents to a
ReadClosertype. After more experimenting with this, we really want to be able to support the closing behavior.