feat: add Headers/Queries as first class citizens in RequestOf type #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsteenb2
commented
Nov 5, 2024
| @@ -155,24 +155,20 @@ type reqMeta struct { | |||
| Context json.RawMessage `json:"context"` | |||
| AccessToken string `json:"access_token"` | |||
| Method string `json:"method"` | |||
| Params struct { | |||
adi-malhotra
reviewed
Nov 5, 2024
runner_http.go
Outdated
Comment on lines
158
to
159
| Header http.Header `json:"header"` | ||
| Query url.Values `json:"query"` |
There was a problem hiding this comment.
Why are these singular here and multiple elsewhere?
There was a problem hiding this comment.
matched the previous naming. I can fix that up though, good question 👍
adi-malhotra
approved these changes
Nov 5, 2024
jsteenb2
force-pushed
the
chore/replace_params
branch
from
47456c4 to
a4b79e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we now have the means to provide paremeterization via queries/headers within fusion via jsonschema. This is now possible and we can make it a first class citizen.