Version 1.0.0 release #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsteenb2
reviewed
Jul 23, 2024
README.md
Outdated
|
|
||
| ### `falconpy` | ||
| As of version 1.0.0, `falconpy` no longer ships with Foundry Function Python. |
There was a problem hiding this comment.
nit: drop the first two lines here. No one knows we had falconpy in this repo as the number of users is quite low. Just remove the noise and get straight to the point below. Run the risk of confusing folks here with to much context.
jsteenb2
reviewed
Jul 24, 2024
| @@ -106,3 +105,19 @@ def call(func): | |||
| )) | |||
|
|
|||
| return call | |||
|
|
|||
|
|
|||
| def cloud() -> str: | |||
jsteenb2
approved these changes
Jul 24, 2024
johns31459
force-pushed
the
20240723/additional-request-params
branch
from
472594f to
f0a6233
Compare
johns31459
force-pushed
the
20240723/additional-request-params
branch
from
f0a6233 to
ed295f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligns with Go SDK (https://github.com/CrowdStrike/foundry-fn-go):
crowdstrike.foundry.function.cloud()to fetch a falconpy compatible cloud identifier.Loggeras a parameter to each handler.