Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GT-2452 Add support for new page collection type #2425

Merged
merged 11 commits into from
Feb 3, 2025

Conversation

levieggertcru
Copy link
Collaborator

@levieggertcru levieggertcru commented Jan 29, 2025

This PR adds a new page type (page-collection) to the mobile content renderer.

Changes in this PR include:

  • Add feature flag page collection to the renderer parser. Controlled by Firebase remote config.
  • Add MobileContentRendererView and MobileContentRendererViewModel which now subclasses MobileContentPagesView. Wasn't necessary, but does move some specific logic for the renderer out of MobileContentPagesView and MobileContentPagesViewModel.
  • Change name MobileContentPagesPage.swift to MobileContentRendererInitialPage.swift.
  • Change name MobileContentPagesInitialPageConfig.swift to MobileContentRendererInitialPageConfig.swift.
  • Add view and view model for the new page collection page.
  • Removed CYOA page view factory, wasn't needed since those views are part of the mobile content page view factory.
  • Added a horizontal padding of 16 points to content stacks.

@levieggertcru levieggertcru marked this pull request as draft January 29, 2025 15:54
@levieggertcru levieggertcru changed the title GT-2452 Add feature page collection GT-2452 Add support for new page collection type Jan 29, 2025
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.94%. Comparing base (414fdd9) to head (307cd4d).
Report is 16 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2425      +/-   ##
===========================================
+ Coverage    95.92%   95.94%   +0.01%     
===========================================
  Files           62       62              
  Lines         5323     5323              
===========================================
+ Hits          5106     5107       +1     
+ Misses         217      216       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@levieggertcru levieggertcru marked this pull request as ready for review January 31, 2025 15:53
@levieggertcru levieggertcru merged commit 83c7fde into develop Feb 3, 2025
4 checks passed
@levieggertcru levieggertcru deleted the GT-2452-support-new-page-collection-type branch February 3, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant