Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a check to check the deletedAt column before showing or updatin… #124

Open
wants to merge 1 commit into
base: release-01
Choose a base branch
from

Conversation

Bikilaketema
Copy link
Collaborator

This pull request includes changes to the AccountService class in src/modules/admin/account/account.service.ts to enhance the handling of account retrieval and updates by adding checks for soft-deleted accounts and throwing appropriate errors when accounts are not found.

Enhancements to account handling:

  • Added a check for deletedAt being null when finding multiple accounts in the findAll method, and introduced an error throw if no accounts are found.
  • Modified the findOne method to include a check for deletedAt being null and to throw an error if the account is not found.
  • Updated the update method to include a check for deletedAt being null before attempting to update an account, and added an error throw if the account is not found.…g account

@Bikilaketema Bikilaketema requested a review from bengeos February 9, 2025 21:35
@Bikilaketema Bikilaketema self-assigned this Feb 10, 2025
@Bikilaketema Bikilaketema added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Review
Development

Successfully merging this pull request may close these issues.

refactor-the-getall-show-update-methods-onaccount-endpoint-to-not-show-deleted-accounts
1 participant