-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate hypothesis testing 178390751 #320
base: master
Are you sure you want to change the base?
Conversation
1ee1227
to
6ef195c
Compare
Codecov Report
@@ Coverage Diff @@
## master #320 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 20 19 -1
Lines 4639 4848 +209
==========================================
+ Hits 4639 4848 +209
Continue to review full report at Codecov.
|
bfc1057
to
f9ab2ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I'm out of time for today, but here are some to get you started.
4f99665
to
161e9e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I didn't get far when I discovered a basic error in how this is organized. Indices need to be computed in the measure and not in assembler. Then assembler's role is just to adjust the indices from payload-order to sorted-order. Everything else (like ._assemble_matrix
happens the same way as any other measure.
0a1021a
to
2f55a82
Compare
56b1896
to
92db5fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, LGTM after some docstring improvement :)
92db5fd
to
8b73013
Compare
41c3f50
to
8f63631
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had originally wanted to go through and understand the whole thing, which I haven't had time to do yet. (Not sure what you were asking for, but since Steve already approved, is it good?)
One comment about a docstring change
@@ -1300,7 +1300,7 @@ def reference_column_idx(self): | |||
"""Optional int index of base column as reference for the pairwise sig tests.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docstring is out of date now, right?
"Optional int index" -> "Optional element id" (which is either an int/str if you want to have the type)
(I think Mike's arguing in slack that this should be called the "code", but this would be the only place we use that terminology)
f82bb2d
to
ea06064
Compare
Notion page: https://www.notion.so/crunch/Sort-by-value-Transform-for-Dashboards-and-Export-PRD-759062891aa2471e8f9ca9c766ee6e72#440ab7f0a4234e8eb811678762ffb17a
Goal: support sort-by-value for pairwise significance measures.
All pairwise significance measures have been moved from
methods
tolazyproperties
.The new way to specify the pairwise sig column baseline is to use a new object in the transforms: