Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IT] Fixing translations + adding lesson 11 #690

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

[IT] Fixing translations + adding lesson 11 #690

wants to merge 26 commits into from
+2,161 −39

Conversation

lonasozo
Copy link

@lonasozo lonasozo commented Aug 4, 2022

Translation improvement

  • [✓ ] I did these translations myself and own copyright for them
  • [ ✓] I didn't use a machine to do these translations
  • [ ✓] I assign all copyright to Loom Network for these translations

@lonasozo lonasozo changed the title Update 3-msgsender.md Update ITA translations Aug 4, 2022
@lonasozo lonasozo marked this pull request as draft August 7, 2022 07:37
@lonasozo lonasozo changed the title Update ITA translations Update ITA translations (in progress) Aug 7, 2022
@lonasozo lonasozo changed the title Update ITA translations (in progress) [IT] Update translations (in progress) Aug 7, 2022
lonasozo added 13 commits August 7, 2022 09:51
@lonasozo
Update 06-zombiecooldowns.md
a7cb669
@lonasozo
Update 07-zombiecooldowns2.md
55b6288
@lonasozo
Update 09-zombiemodifiers.md
f8a7f84 
Fixed wrong suggestion inside description in step 2 
request -> require
@lonasozo
Update 12-forloops.md
269c40d
@lonasozo
Update payable.md
5cfe473
@lonasozo
Update battle-02.md
b76e1ee
@lonasozo
Update battle-04.md
5391cab 
English text removed
@lonasozo
Update 01.md
6e5c9c8 
English text removed
@lonasozo
Update 02.md
7c0e9d5 
fixed typo: missed space from two words
@lonasozo
Update 04.md
21b1d39
@lonasozo
Update 07.md
b76c7b9 
Code specification to solve the quest has been translated, got error while submit them. Removed translation on them.
@lonasozo
Update 08.md
f9ef898 
Code specification translated and error on submit of the code, removed.
@lonasozo
Create 00-overview.md
fdc8736
@lonasozo
Copy link
Author

lonasozo commented Aug 7, 2022 •
edited
Loading

Found that after the /6, the /11 and others (that are available on the website) has not been translated and files does not exists.
I'll work on it.
In the while if you want to merge these fixes, let me know and I'll change the PR from draft to open, creation and translation of missed chapters can be done next (requires a little bit of time to be done).

@lonasozo lonasozo changed the title [IT] Update translations (in progress) [IT] Updating/Adding translations (in progress) Aug 12, 2022
@lonasozo lonasozo changed the title [IT] Updating/Adding translations (in progress) [IT] Updating/Adding translations Aug 12, 2022
@lonasozo lonasozo changed the title [IT] Updating/Adding translations [IT] Fixing translations + adding lesson 11 Aug 12, 2022
@lonasozo lonasozo marked this pull request as ready for review August 12, 2022 15:27
Liiuc
Liiuc approved these changes Oct 18, 2022
View reviewed changes
Copy link

@Liiuc Liiuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the translations, pretty good overall !

Liiuc
Liiuc approved these changes Oct 18, 2022 •
edited
Loading
View reviewed changes
@p-lorenzo
Copy link

p-lorenzo commented Oct 18, 2022 •
edited
Loading

I was about to create a PR with some of the translation issues you fixed, LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-lorenzo p-lorenzo p-lorenzo approved these changes

@Liiuc Liiuc Liiuc approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lonasozo @p-lorenzo @Liiuc