Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various: add public IP selector setting #822

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Greelan
Copy link
Collaborator

@Greelan Greelan commented Jun 5, 2024

No description provided.

@Greelan Greelan requested a review from IceOfWraith June 5, 2024 12:11
IceOfWraith
IceOfWraith previously approved these changes Jun 6, 2024
@IceOfWraith
Copy link
Collaborator

Remind me what the issue was with merging this one? I know we talked about it somewhere already.

@IceOfWraith IceOfWraith marked this pull request as draft July 4, 2024 19:31
@Greelan
Copy link
Collaborator Author

Greelan commented Jul 4, 2024

The manifest doesn't know about the kvp vars so can't write them into configs

@Greelan
Copy link
Collaborator Author

Greelan commented Jul 5, 2024

@IceOfWraith see CubeCoders/AMP#1120

@sirbaas
Copy link

sirbaas commented Sep 29, 2024

I'm interessed in the PublicIP variable that is add to Astroneer config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants