Fix memory leaks/suboptimal logic and X errors

README.md

@@ -157,6 +157,7 @@ To edit the order in which these modes are selected, adjust the `modes` variable
 - Remove several unused dependencies, add option to compile without `stdio.h`
 - Move all Xlib utility functions into `x.h`
 - Move files into appropriate folders, cleaning up the appearance of the repository
+- Add `above_enabled` check to avoid X error
 
 ### v1.2.0
 - Add support for pre-mapped windows being tiled, thereby greatly improving the `reset` command
@@ -227,7 +228,6 @@ To edit the order in which these modes are selected, adjust the `modes` variable
 - Investigate and resolve any remaining memory leaks
 - Fix flickering upon dragging chromium tabs
 - Fix incongruency between client-toggled and window manager-wide fullscreen
-- Clean up util.h
 
 ## What Will (Likely) Never be Implemented
 

include/events.h

@@ -54,7 +54,10 @@ void map_request(XEvent *e){
    * Window with _NET_WM_STATE_ABOVE
    * set always has precedence
    */
-  XMapRaised(dpy, above);
+  if(above_enabled &&
+     above != 0){
+    XMapRaised(dpy, above);
+  }
 
   if(wintype == window_dock || wintype == window_taskbar){
     multihead_addbar(ev->window);

include/list.h

@@ -155,12 +155,19 @@ void list_pop(node *root, node *elem){
  * Frees an entire list
  */
 void list_free(node *root){
+  /*
   list_foreach_noroot(root){
     if(itr->prev != NULL){
       free(itr->prev);
     }
   }
-  free(itr);
+  free(itr);*/
+
+  list_foreach_reverse(root){
+    if(itr->next != NULL){
+      free(itr->next);
+    }
+  }
 }
 
 /*

include/multihead.h

@@ -111,7 +111,9 @@ void multihead_resize(){
     m->x = crtc_info->x;
     m->y = crtc_info->y;
     i++;
+    XRRFreeCrtcInfo(crtc_info);
   }
+  XRRFreeScreenResources(screen_resources);
 }
 
 /*

include/x.h

@@ -63,6 +63,7 @@ void x_init(){
   root = DefaultRootWindow(dpy);
   screen = DefaultScreenOfDisplay(dpy);
   focused = 0;
+  above = 0;
   bars = list_init();
 
   XSetErrorHandler(&on_x_error);