Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add biome return value for shipwrecks in isViableStructurePos, similar to villages #111

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AeroAstroid
Copy link
Contributor

Convenient to have for analysis, as beach vs. ocean have different behavior when rolling for ship type and orientation (and thereby, the resulting loot)

@AeroAstroid
Copy link
Contributor Author

Didn't realize this before but this causes a collision because regular oceans are ID 0 which clashes with the return value for an invalid structure position, my apologies. Still, I think there's value in refactoring this function to maybe add a pointer to hold a biome return value, in a similar way to how getStructurePos does so for position. I'll keep this as a draft for the time being if that's fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant