Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(phone_verify): Add Kavenegar backend #34
base: master
Are you sure you want to change the base?
feat(phone_verify): Add Kavenegar backend #34
Changes from 12 commits
5f3d7f6
d9468a1
a061379
9c4b316
5596a2e
7dcdc99
6659037
ccbb2e9
ca42409
6381fdc
de56ea4
5884cde
53c2e27
87281a7
ca4faad
92681ff
7f2e976
1847bac
e4532ba
c59e927
391e505
d3aec32
b1af51b
987cbca
facc894
b10b1da
0c45d81
18707fd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The API here states that sender should be a list of strings and you're providing a single sender here 🤔
https://github.com/kavenegar/kavenegar-python
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @SepehrHasanabadi
Can you please have a look at this when you get the time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ping @SepehrHasanabadi Can you please have a look at this conversation? Have you tested these changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, @SepehrHasanabadi, have a look at this comment as well.