Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbols #321

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Symbols #321

merged 2 commits into from
Apr 23, 2024

Conversation

hawk93
Copy link
Contributor

@hawk93 hawk93 commented Feb 11, 2024

Hi, I added a poc to implement symbol usage, closing #307

@Cweili
Copy link
Owner

Cweili commented Apr 23, 2024

Thank you for your contribution.

However, I have noticed that the use of CSS Variables, which may reduce browser compatibility. It could potentially result in a breaking change.

@Cweili Cweili merged commit d274cd3 into Cweili:master Apr 23, 2024
1 check passed
@Cweili
Copy link
Owner

Cweili commented Apr 23, 2024

There are still some work to be completed for this feature, such as adding test cases and documentation. I will add them when I have free time, or you are welcome to continue submitting PRs.

Commits have been merged into branch feat/symbols.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants