Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep the order of existing entries. #52

Merged
merged 7 commits into from
Jan 18, 2024
Merged

Keep the order of existing entries. #52

merged 7 commits into from
Jan 18, 2024

Conversation

Haruma-K
Copy link
Member

既存エントリの順番を保持する形でApplyを行うように修正しました。

Related Issue: #49

経緯

  • 上記のIssueに対して、以下のPRをマージした
  • この実装だと全てのアセットに対して適用する際にはパスの順にソートされるのに、個別のアセットに対して適用した場合(新しくアセットを作った場合)には末尾に追加されてしまう
    • その後全てのアセットに対して適用すると、やはり順番が変わってしまう
  • そのためソートをやめて既存の順番を保持する実装に変更しました

Base automatically changed from feature/performance_tuning to main January 18, 2024 08:50
@Haruma-K Haruma-K merged commit d59e97d into main Jan 18, 2024
1 check passed
@Haruma-K Haruma-K deleted the feature/sorting branch January 18, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants