Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 1.8 support #1551

Merged
merged 3 commits into from
Jan 12, 2025
Merged

Ruby 1.8 support #1551

merged 3 commits into from
Jan 12, 2025

Conversation

prabhu
Copy link
Collaborator

@prabhu prabhu commented Jan 12, 2025

There are no official container images for Ruby 1.8, so this PR adds one.

ruby1.8 hurray

Managed to generate a partial SBOM (BUNDLE_INSTALL_ARGS=--without test) for this repo branch with no lock file and over 11 years old (older than even OWASP and CycloneDX). Had to add a bunch of gem install to the image make things work though.

bom.json

Signed-off-by: Prabhu Subramanian <[email protected]>
Signed-off-by: Prabhu Subramanian <[email protected]>
@prabhu
Copy link
Collaborator Author

prabhu commented Jan 12, 2025

Todo

  • --deep mode is currently not working for Ruby 1.8. I couldn't find a way to install Node 20 in a debian:8 image, so there is no cdxgen image with Ruby 1.8. When I tried with a Ruby 2 or 3 image in a split workflow (as explained in the base-images README), our macro to identify module names was failing. This is a shame, since atom does support Ruby 1.8 but without the module names, reachables slices will have a lower precision.

Signed-off-by: Prabhu Subramanian <[email protected]>
@prabhu prabhu merged commit 3d88690 into master Jan 12, 2025
23 of 24 checks passed
@prabhu prabhu deleted the feature/ruby18 branch January 12, 2025 17:47
@prabhu
Copy link
Collaborator Author

prabhu commented Jan 12, 2025

One step forward and two steps back. This PR broke existing Ruby images. Didn't know that --no-ri argument got removed.

@prabhu prabhu added sponsored and removed pro bono labels Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant