Ensuring that the evidence.identity format is maintained after components are trimmed #1591
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensuring that the evidence.identity format is maintained after components are trimmed
|
Could you kindly sign the commits by following the instructions here? https://github.com/CycloneDX/cdxgen/pull/1591/checks?check_run_id=36016547177 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1541
With spec version 1.5, some evidence.identity objects are cast to arrays and failing the format validation. This change checks if the original evidence.identity is an array, if it's not, it casts it back into the original object.
This change saves the original
Array.isArraycheck as a variable. After the logic required is completed and if the value of the variable isfalse, then it sets the value back to the original object.Tested on a codebase where the validation had previously failed and it now passes the validation.