Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix QR bug and cuQuantum QR #254

Merged
merged 4 commits into from
Sep 11, 2023
Merged

Fix QR bug and cuQuantum QR #254

merged 4 commits into from
Sep 11, 2023

Conversation

j9263178
Copy link
Collaborator

@j9263178 j9263178 commented Sep 9, 2023

Part of this PR address #203 and #68.

cuQuantum QR routine will now be used when the input UniTensor is on cuda device.
In that routine I currently disable the return_tau = true option since the API doesn't store tau or provide ways to retrieve it.

@kaihsin
Copy link
Member

kaihsin commented Sep 9, 2023

Make sure all the tests are passed

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #254 (6d74402) into dev-master (9fb8b53) will increase coverage by 0.00%.
The diff coverage is 22.22%.

@@             Coverage Diff             @@
##           dev-master     #254   +/-   ##
===========================================
  Coverage       13.58%   13.58%           
===========================================
  Files             276      276           
  Lines           54898    54902    +4     
  Branches        24564    24564           
===========================================
+ Hits             7457     7458    +1     
- Misses          41630    41633    +3     
  Partials         5811     5811           
Files Changed Coverage Δ
src/linalg/Qr.cpp 22.56% <0.00%> (ø)
src/linalg/linalg_internal_interface.cpp 89.34% <ø> (ø)
src/linalg/linalg_internal_cpu/QR_internal.cpp 19.04% <25.00%> (+0.23%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kaihsin kaihsin merged commit 9fa12bc into dev-master Sep 11, 2023
4 checks passed
@kaihsin kaihsin deleted the gpu-cuquantum-qr branch September 11, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants