Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak ncon and network & Fix failed tests #257

Merged
merged 2 commits into from
Sep 10, 2023
Merged

Tweak ncon and network & Fix failed tests #257

merged 2 commits into from
Sep 10, 2023

Conversation

j9263178
Copy link
Collaborator

@j9263178 j9263178 commented Sep 10, 2023

  1. ncon() now utilizing the Network.construct() to pass the argument more directly.
  2. Update Network.construct().
  3. Update ncon and tests.
  4. Update network tests, add the reuse scenario.
  5. Fix BkUt_Svd_truncate1 and Gesvd.none_isU_isVT tests. (#237)

@codecov
Copy link

codecov bot commented Sep 10, 2023

Codecov Report

❗ No coverage uploaded for pull request base (dev-master@543ac20). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             dev-master     #257   +/-   ##
=============================================
  Coverage              ?   13.58%           
=============================================
  Files                 ?      276           
  Lines                 ?    54898           
  Branches              ?    24564           
=============================================
  Hits                  ?     7457           
  Misses                ?    41630           
  Partials              ?     5811           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kaihsin kaihsin merged commit 9fb8b53 into dev-master Sep 10, 2023
4 checks passed
@kaihsin kaihsin deleted the fixing_tests branch September 10, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants