Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix arithmetic bug #368

Merged
merged 13 commits into from
Dec 1, 2023
Merged

fix arithmetic bug #368

merged 13 commits into from
Dec 1, 2023

Conversation

jeffry1829
Copy link
Collaborator

@jeffry1829 jeffry1829 commented Nov 14, 2023

fix #363

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 45 lines in your changes are missing coverage. Please review.

Comparison is base (5e4ebf5) 17.83% compared to head (f3efa90) 17.81%.
Report is 5 commits behind head on dev-master.

Files Patch % Lines
src/linalg/Div.cpp 7.14% 8 Missing and 5 partials ⚠️
src/linalg/Sub.cpp 7.14% 9 Missing and 4 partials ⚠️
src/linalg/Add.cpp 25.00% 4 Missing and 5 partials ⚠️
src/linalg/Mul.cpp 25.00% 4 Missing and 5 partials ⚠️
src/ncon.cpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           dev-master     #368      +/-   ##
==============================================
- Coverage       17.83%   17.81%   -0.03%     
==============================================
  Files             220      220              
  Lines           48726    48761      +35     
  Branches        19923    19955      +32     
==============================================
- Hits             8690     8686       -4     
- Misses          35841    35871      +30     
- Partials         4195     4204       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kaihsin kaihsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make corresponding change for Add and Mul

src/linalg/Mul.cpp Outdated Show resolved Hide resolved
@jeffry1829 jeffry1829 requested a review from kaihsin December 1, 2023 11:27
@jeffry1829 jeffry1829 merged commit c93b318 into dev-master Dec 1, 2023
4 checks passed
@jeffry1829 jeffry1829 deleted the fix_real_complex_sub branch December 1, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants