Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zn symmetry combine/inverse rule #391

Merged
merged 6 commits into from
Dec 1, 2023
Merged

Zn symmetry combine/inverse rule #391

merged 6 commits into from
Dec 1, 2023

Conversation

j9263178
Copy link
Collaborator

@j9263178 j9263178 commented Dec 1, 2023

#390.
Combine rule is the same (a+b)%N.
Inverse rule is changed to behave like Inverse(a) = -a+N.

@j9263178 j9263178 marked this pull request as draft December 1, 2023 06:54
@j9263178 j9263178 changed the title Zn symmetry reverse rule Zn symmetry combine rule Dec 1, 2023
@j9263178 j9263178 changed the title Zn symmetry combine rule Zn symmetry combine/inverse rule Dec 1, 2023
@j9263178 j9263178 marked this pull request as ready for review December 1, 2023 09:57
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (29ba967) 17.79% compared to head (c06e131) 17.74%.
Report is 17 commits behind head on dev-master.

Additional details and impacted files
@@              Coverage Diff               @@
##           dev-master     #391      +/-   ##
==============================================
- Coverage       17.79%   17.74%   -0.06%     
==============================================
  Files             220      220              
  Lines           48736    48713      -23     
  Branches        19932    19918      -14     
==============================================
- Hits             8672     8642      -30     
- Misses          35868    35895      +27     
+ Partials         4196     4176      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeffry1829 jeffry1829 merged commit 694f543 into dev-master Dec 1, 2023
4 checks passed
@jeffry1829 jeffry1829 deleted the zn_reverse branch December 1, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants