Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change TOUT default rowrank #401

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Change TOUT default rowrank #401

merged 2 commits into from
Jul 26, 2024

Conversation

j9263178
Copy link
Collaborator

@j9263178 j9263178 commented Dec 5, 2023

#394.
Change TOUT default (no ";" provided) rowrank to int(output_rank/2).

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (c93b318) 17.81% compared to head (2524799) 17.81%.

Files Patch % Lines
src/RegularNetwork.cpp 39.47% 3 Missing and 20 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           dev-master     #401   +/-   ##
===========================================
  Coverage       17.81%   17.81%           
===========================================
  Files             220      220           
  Lines           48761    48778   +17     
  Branches        19955    19966   +11     
===========================================
+ Hits             8686     8692    +6     
- Misses          35871    35874    +3     
- Partials         4204     4212    +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@j9263178 j9263178 marked this pull request as ready for review March 7, 2024 11:26
@jeffry1829 jeffry1829 merged commit c6dddb6 into dev-master Jul 26, 2024
4 checks passed
@jeffry1829 jeffry1829 deleted the tout-rowrank branch July 26, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants