Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Haoti/arnoldi ut #413

Merged
merged 13 commits into from
May 9, 2024
Merged

Haoti/arnoldi ut #413

merged 13 commits into from
May 9, 2024

Conversation

hunghaoti
Copy link
Collaborator

Add function Arnoldi support for Dense UniTensor.

Copy link
Member

@kaihsin kaihsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest for any internal functions that you don't want to expose, using underscore and lowercase with underscore separators for naming it, instead of Capitalize separator. for example:

GetEig -> _get_eigenval

Other than that LGTM

@hunghaoti
Copy link
Collaborator Author

I would suggest for any internal functions that you don't want to expose, using underscore and lowercase with underscore separators for naming it, instead of Capitalize separator. for example:

GetEig -> _get_eigenval

Other than that LGTM

OK, I will modify it.

@Cytnx-dev Cytnx-dev deleted a comment from codecov bot May 2, 2024
Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 17.66667% with 247 lines in your changes are missing coverage. Please review.

Project coverage is 16.58%. Comparing base (e518b8b) to head (efc880f).

Files Patch % Lines
src/linalg/Lanczos_Exp.cpp 7.32% 107 Missing and 70 partials ⚠️
src/linalg/Arnoldi.cpp 35.77% 1 Missing and 69 partials ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           dev-master     #413      +/-   ##
==============================================
+ Coverage       16.49%   16.58%   +0.09%     
==============================================
  Files             220      221       +1     
  Lines           48275    48388     +113     
  Branches        20126    20241     +115     
==============================================
+ Hits             7961     8027      +66     
+ Misses          36183    36091      -92     
- Partials         4131     4270     +139     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yingjerkao yingjerkao self-requested a review May 7, 2024 09:22
@jeffry1829 jeffry1829 merged commit 10e60b1 into dev-master May 9, 2024
4 checks passed
@jeffry1829 jeffry1829 deleted the haoti/Arnoldi_Ut branch May 9, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants