Remove Magma dependency by using CuSolver Routines #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like the tests and coverage don't cover the gpu version? |
Yes, one possible option is that we might need to link some machine to github action |
|
I'll push test for Det later(along with some fixes), however, cusolver getrf is ridiculously slow, might investigate more |
fix Det output device to gpu when original tensor is in gpu & add tests for Det, make gpu test for Directsum actually happens at gpu
IvanaGyro
reviewed
Oct 2, 2024
|
@jeffry1829 Could you create another PR for 35c95aa ? So this PR doesn't have to wait for the commit for fixing the Det. |
This reverts commit 35c95aa.
Reverted |
Merged
IvanaGyro
approved these changes
Oct 2, 2024
|
Fix #482 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to remove the Magma dependency by replacing magma routines with the corresponding cusolver ones.
It compiles CUDA 11.8, CuTensor 2.0.2.5, CuQuantum 24.08.0.5.