Follow the header guard rule in Google style guide #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not expected to have two header files with the same relative paths related to `include/` and `src/`, so `include/` and `src/` are not encoded into the header guard. For example, the guard of "include/Accessor.hpp" is "CYTNX_ACCESSOR_H_".
Deleted files were replaced by the files in use.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-master #527 +/- ##
===========================================
Coverage 16.54% 16.54%
===========================================
Files 211 211
Lines 48829 48829
Branches 18900 18900
===========================================
Hits 8080 8080
Misses 36603 36603
Partials 4146 4146 ☔ View full report in Codecov by Sentry. |
hunghaoti
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not expected to have two header files with the same relative paths related to
include/andsrc/, soinclude/andsrc/are not encoded into the header guard. For example, the guard of "include/Accessor.hpp" is "CYTNX_ACCESSOR_H_".This PR resolves the issue addressed at #460.
I also deleted the stale files which are not used anymore.