Skip to content

Commit

Permalink
Clarifies logging instructions for insights tab
Browse files Browse the repository at this point in the history
  • Loading branch information
elijahbenizzy committed Aug 28, 2024
1 parent 32a2347 commit b51b221
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 13 deletions.
25 changes: 13 additions & 12 deletions telemetry/ui/src/components/routes/app/InsightsView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -252,12 +252,11 @@ const InsightSubTable = (props: {

export const InsightsView = (props: { steps: Step[] }) => {
const allAttributes: AttributeModel[] = props.steps.flatMap((step) => step.attributes);
let noInsights = true;

const allSpans = props.steps.flatMap((step) => step.spans);

const out = (
<div className="pt-0">
<div className="pt-0 flex flex-col">
<Table dense={1}>
<TableHead>
<TableRow className="hover:bg-gray-100">
Expand All @@ -271,7 +270,6 @@ export const InsightsView = (props: { steps: Step[] }) => {
<TableBody>
{REGISTERED_INSIGHTS.map((insight) => {
if (insight.hasInsight(allAttributes)) {
noInsights = false;
return (
<InsightSubTable
key={insight.insightName}
Expand All @@ -285,14 +283,17 @@ export const InsightsView = (props: { steps: Step[] }) => {
})}
</TableBody>
</Table>
</div>
);
if (noInsights) {
return (
<div>
<h2 className="text-gray-500 max-w-xl">
Use this tab to view summaries of your application -- E.G. LLM call data. To instrument,
and start collecting, see{' '}
<h2 className="text-gray-500 pl-2 pt-4">
Use this tab to view summaries of your application. This automatically picks up on a
variety of attributes, including those populated by{' '}
<a
className="text-dwlightblue"
href={'https://www.traceloop.com/docs/openllmetry/tracing/without-sdk'}
>
opentelemetry instrumentation.
</a>{' '}
-- E.G. LLM call data. To instrument, and start collecting, see{' '}
<a
className="text-dwlightblue"
href={'https://burr.dagworks.io/concepts/additional-visibility/#quickstart'}
Expand All @@ -301,7 +302,7 @@ export const InsightsView = (props: { steps: Step[] }) => {
</a>
</h2>
</div>
);
}
</div>
);
return out;
};
2 changes: 1 addition & 1 deletion telemetry/ui/src/components/routes/app/ReproduceView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export const ReproduceView = (props: {
onClose={() => setIsFlashVisible(false)}
/>
)}
<div className="flex flex-row justify-between">
<div className="flex flex-row justify-between text-gray-700">
<p>
To generate a test case for this step, run the following command.
<a
Expand Down

0 comments on commit b51b221

Please sign in to comment.