Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds validation for the examples #114

Merged
merged 15 commits into from
Mar 30, 2024
Merged

Adds validation for the examples #114

merged 15 commits into from
Mar 30, 2024

Conversation

elijahbenizzy
Copy link
Contributor

@elijahbenizzy elijahbenizzy commented Mar 29, 2024 •
edited
Loading

All examples must adhere to a strict format. We'll be adding a directory with "unstructured" examples that don't adhere.

TODO on this:

  • Fix up all examples
    • conversational-rag
    • hello-world-counter
    • llm-adventure-game
    • multi-agent-collaboration
    • multi-modal-chatbot
    • simple-chatbot-intro
    • streaming-overview

@elijahbenizzy elijahbenizzy force-pushed the example-uniform branch 3 times, most recently from 8aa989d to 5d78c69 Compare March 29, 2024 23:29
@elijahbenizzy elijahbenizzy force-pushed the example-uniform branch 3 times, most recently from 010940a to 29773f6 Compare March 30, 2024 00:18
@elijahbenizzy elijahbenizzy force-pushed the example-uniform branch 2 times, most recently from 36f69ee to f408f6b Compare March 30, 2024 19:57
@elijahbenizzy elijahbenizzy mentioned this pull request Mar 30, 2024
Open
@elijahbenizzy
Copy link
Contributor Author

More work in this, this I think is good enough for now: #116

skrawcz
skrawcz reviewed Mar 30, 2024
View reviewed changes
examples/blog_post/blog.ipynb Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you will need to update links in a few places, e.g. the blog, docs, etc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do post-release

skrawcz
skrawcz approved these changes Mar 30, 2024
View reviewed changes
Copy link
Contributor

@skrawcz skrawcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to update youtube with links too.

@elijahbenizzy elijahbenizzy merged commit 6a8ec8e into main Mar 30, 2024
7 checks passed
@elijahbenizzy elijahbenizzy deleted the example-uniform branch March 30, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skrawcz skrawcz skrawcz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elijahbenizzy @skrawcz