Adds POC "render" view of state #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Some styling/feature notes (I can do these tomorrow):
|
This should help people more easily view/see things. TODOs: - styling - using it for the result too? - enabling future customization
This is pretty basic -- but it seems to work. This handles: - null values - arrays - dicts/objects Tries to intelligently provide indexing (but for objects it could be better). Ideally we'd display the JSON path or something...
skrawcz
force-pushed
the
sketch_form_view
branch
from
2d3c43b to
28607c4
Compare
|
Your subscription is not currently active. Please add a payment method at https://app.ellipsis.dev |
|
Three changes:
|
elijahbenizzy
force-pushed
the
sketch_form_view
branch
from
732523c to
feb5caf
Compare
|
OK, improved: |
|
@elijahbenizzy you didn't commit the rendered toggle. |
elijahbenizzy
force-pushed
the
sketch_form_view
branch
from
feb5caf to
cd9e91d
Compare
|
the toggle is effectively invisible 😆 |
elijahbenizzy
force-pushed
the
sketch_form_view
branch
from
cd9e91d to
b95974f
Compare
data/state view Expandable fields, ensures they all use the same classes, adds some left-borders + highlighting
elijahbenizzy
force-pushed
the
sketch_form_view
branch
from
b95974f to
52aeeba
Compare
elijahbenizzy
approved these changes
Apr 1, 2024
There was a problem hiding this comment.
Ready to ship, assuming we can figure out why its working on my machine but not @skrawcz's...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help people more easily view/see things.
TODOs: