Initializes telemetry UI #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elijahbenizzy
force-pushed
the
burr-ui
branch
3 times, most recently
from
4ee7f0c to
be6d032
Compare
|
Ok, long list of TODOs before getting this out + getting out v0
|
elijahbenizzy
force-pushed
the
burr-ui
branch
3 times, most recently
from
66bba0c to
0ed7eab
Compare
We returned `None` in `step` -- we now bypass calling the lifecycle hook
This allows us to track burr's execution locally.
This is a little quick/dirty. The intention is that the local data model will work and remain stable through releases (if not, we will have automated migration). The contract between server and UI is not stable and will likely change. This is not included in the semantic versioning yet for those reasons. Basic design: 1. FastAPI for server 2. Pydantic for data types 3. Aiofiles + quick file-list for db (filesystem) access 4. Simple BE abstraction to start forcing the difference between API and implementation (though this will change) 5. uvicorn to run
Design choices: 1. Uses React (plain)/CRA. Simple and tried/true. 2. Uses react-query -- easy to cache state/refetch 3. Uses openapi-typescript-codegen to generate a fetch client 4. Uses tailwind catalyst components. Tailwind license expressly allows this use-case as follows: Creating a web application where the primary purpose is clearly not to simply re-distribute the components (like a conference organization app that uses the components for its UI for example) that is free and open source, where the source code is publicly available. link here: https://tailwindui.com/license
We just delegate to the tracking server/client for tracking
elijahbenizzy
force-pushed
the
burr-ui
branch
5 times, most recently
from
e92cf45 to
dd6cf48
Compare
elijahbenizzy
force-pushed
the
burr-ui
branch
from
dd6cf48 to
bef8c01
Compare
elijahbenizzy
force-pushed
the
burr-ui
branch
3 times, most recently
from
0437da9 to
7020918
Compare
We can now install and get all static assets. Also adds CLI for admin/user work -- TODO -- split it out and do dynamic imports...
This happens when the error is too long -- this fixes a few issues around the layout in the data view.
Copied from Hamilton
Also renames commands/makes some features of the CLI optional to go along with the developer-facing docs.
This is set to False for now as we don't have examples, but we will be adding them.
Before this we had synchronous hooks running twice for an async call. This adds an internal method that has the options to bypass hooks, and calls that from the step() function.
elijahbenizzy
force-pushed
the
burr-ui
branch
from
7020918 to
0d1766d
Compare
skrawcz
reviewed
Feb 23, 2024
skrawcz
approved these changes
Feb 23, 2024
We want everyone using Burr to use it.
elijahbenizzy
force-pushed
the
burr-ui
branch
from
b647831 to
1797b2e
Compare
|
Done with this portion, track V0 in #29 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design: