Solves #31 -- enables deletion operation on state #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elijahbenizzy
changed the title
elijahbenizzy
force-pushed
the
fix-state-wipe
branch
2 times, most recently
from
31729c6 to
421a757
Compare
skrawcz
reviewed
Feb 25, 2024
We weren't respecting it before. This handles that. This just measures the delete operations and reapplies it. That said, this is not the best way of doing things -- see #33 for a more involved approach. Note we've also relaxed the restrictions on modifications for delete/write -- this is necessary for the current workaround.
Streamlit creates a ton of junk. This solves #35
elijahbenizzy
force-pushed
the
fix-state-wipe
branch
from
421a757 to
53eec30
Compare
skrawcz
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't respecting it before. This handles that. This just measures the delete operations and reapplies it. That said, this is not the best way of doing things -- see #33 for a more involved approach.