Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds pagination to apps view page #346

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Adds pagination to apps view page #346

merged 1 commit into from
Aug 28, 2024

Conversation

elijahbenizzy
Copy link
Contributor

This is not perfect -- but it'll do. The caveat is that parent/child pointers aren't always found -- we need to add that to the API.

[Short description explaining the high-level reason for the pull request]

Changes

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

@skrawcz
Copy link
Contributor

skrawcz commented Aug 28, 2024

@elijahbenizzy node.js error

@elijahbenizzy
Copy link
Contributor Author

#342

@skrawcz
Copy link
Contributor

skrawcz commented Aug 28, 2024

The caveat is that parent/child pointers aren't always found -- we need to add that to the API.

New issue?

@elijahbenizzy
Copy link
Contributor Author

image

partition_key: Optional[str],
limit: int = 100,
offset: int = 0,
) -> Tuple[Sequence[ApplicationSummary], bool]:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bool? this should be int right?

@skrawcz
Copy link
Contributor

skrawcz commented Aug 28, 2024

image

where is the pagination?

@elijahbenizzy
Copy link
Contributor Author

image

One left todo -- add ... to show that we have more pages. In the code there's aline on where to do it.

This is not perfect -- but it'll do. The caveat is that parent/child
pointers aren't always found -- we need to add that to the API.
@elijahbenizzy elijahbenizzy merged commit 1e865b1 into main Aug 28, 2024
12 checks passed
@elijahbenizzy elijahbenizzy deleted the pagination branch August 28, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants