-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds pagination to apps view page #346
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elijahbenizzy
force-pushed
the
pagination
branch
from
August 28, 2024 22:15
379abd2
to
ff73f02
Compare
@elijahbenizzy node.js error |
elijahbenizzy
force-pushed
the
pagination
branch
from
August 28, 2024 22:30
ff73f02
to
10625a2
Compare
New issue? |
skrawcz
reviewed
Aug 28, 2024
burr/tracking/server/backend.py
Outdated
partition_key: Optional[str], | ||
limit: int = 100, | ||
offset: int = 0, | ||
) -> Tuple[Sequence[ApplicationSummary], bool]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bool? this should be int right?
skrawcz
reviewed
Aug 28, 2024
This is not perfect -- but it'll do. The caveat is that parent/child pointers aren't always found -- we need to add that to the API.
elijahbenizzy
force-pushed
the
pagination
branch
from
August 28, 2024 22:58
10625a2
to
c82b0be
Compare
skrawcz
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not perfect -- but it'll do. The caveat is that parent/child pointers aren't always found -- we need to add that to the API.
[Short description explaining the high-level reason for the pull request]
Changes
How I tested this
Notes
Checklist