fix: Improve error message for SQLitePersister #417

[arpitgupta-it]

[Short description explaining the high-level reason for the pull request]

Changes

How I tested this

Notes

Checklist

• PR has an informative and human-readable title (this will be pulled into the release notes)
• Changes are limited to a single goal (no scope creep)
• Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
• Any change in functionality is tested
• New functions are documented (with a description, list of inputs, and expected output)
• Placeholder code is flagged / future TODOs are captured in comments
• Project documentation has been updated if adding/changing functionality.

---

Important

Add initialization check for persisters in with_state_persister to prevent runtime errors with uninitialized persisters.

• Behavior:
  • Add check in with_state_persister in application.py to raise RuntimeError if persister is not initialized.
• Persistence:
  • Add _initialized attribute and is_initialized() method to SQLLitePersister in persistence.py to track initialization state.

^{This description was created by for 5e31502. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 5e31502 in 39 seconds

More details

• Looked at 40 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. burr/core/application.py:2212

• Draft comment:
  The error message could be more concise and consistent with other error messages in the codebase. Consider rephrasing it for clarity.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The PR introduces a check for the initialization of the persister before using it. This is a good practice to ensure that the persister is ready to be used. However, the error message could be improved for clarity and consistency.

Workflow ID: wflow_OXqUxnREvdXATx7U

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[skrawcz]

on the right track, some more comments!

[arpitgupta-it]

Suggested changed added!

[skrawcz]

I think things look good. Asking @elijahbenizzy for review.

[elijahbenizzy]

Looking good! Thank you! Left a few comments -- should be easy to fix up.

[arpitgupta-it]

Hi @elijahbenizzy and @skrawcz,

I’ve reviewed the feedback and the discussions above, but I’m a bit unsure about the specific changes that still need to be made. Could you please clarify what needs to be updated or adjusted in the PR based on the comments so far?

I want to make sure everything is aligned before moving forward with the changes.

Thanks!

[skrawcz]

Hi @elijahbenizzy and @skrawcz,

I’ve reviewed the feedback and the discussions above, but I’m a bit unsure about the specific changes that still need to be made. Could you please clarify what needs to be updated or adjusted in the PR based on the comments so far?

I want to make sure everything is aligned before moving forward with the changes.

Thanks!

They were very minor things -- you can see my commit for them; thought that would be easier than explaining. I think we should be good to go after these changes.

[arpitgupta-it]

Thanks for handling the updates @skrawcz ! Looks like we’re all set... 🤞

[elijahbenizzy]

Looks good!