Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing CSS #465

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Add missing CSS #465

merged 1 commit into from
Dec 6, 2024

Conversation

skrawcz
Copy link
Contributor

@skrawcz skrawcz commented Dec 6, 2024

Oops

Changes

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

Important

Adds testimonials.css for styling testimonial components with layout, appearance, and hover effects.

  • CSS Addition:
    • Adds testimonials.css to docs/_static.
    • Styles .testimonial-container for layout with flexbox, wrapping, and centered alignment.
    • Styles .testimonial-card with background, border, shadow, and hover effect.
    • Styles .testimonial-photo img with circular shape and fixed size.
    • Styles .testimonial-content elements (p, h4, span) with specific fonts and colors.

This description was created by Ellipsis for 0c3c766. It will automatically update as commits are pushed.

@skrawcz skrawcz merged commit 79137e3 into main Dec 6, 2024
11 checks passed
@skrawcz skrawcz deleted the add_missing_css branch December 6, 2024 19:45
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 0c3c766 in 13 seconds

More details
  • Looked at 54 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. docs/_static/testimonials.css:1
  • Draft comment:
    The PR description lacks details about the changes made and how they were tested. Consider providing more information in the PR description to help reviewers understand the context and purpose of these changes.
  • Reason this comment was not posted:
    Confidence changes required: 33%
    The CSS file looks well-structured and follows best practices. However, the PR description lacks details about the changes and testing.

Workflow ID: wflow_LK8PVvKgv13xiQKP


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

github-actions bot commented Dec 6, 2024

A preview of is uploaded and can be seen here:

https://burr.dagworks.io/pull/465

Changes may take a few minutes to propagate. Since this is a preview of production, content with draft: true will not be rendered. The source is here: https://github.com/DAGWorks-Inc/burr/tree/gh-pages/pull/465/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant