Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completes B letter flake8-bugbear rules #1099

Merged
merged 3 commits into from
Aug 20, 2024
Merged

Completes B letter flake8-bugbear rules #1099

merged 3 commits into from
Aug 20, 2024

Conversation

skrawcz
Copy link
Collaborator

@skrawcz skrawcz commented Aug 18, 2024

Refactors to take these into account.

Turns on B.

Changes

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

Refactors to take this rule into account.
examples/LLM_Workflows/image_telephone/streamlit.py Outdated Show resolved Hide resolved
contrib/setup.py Outdated Show resolved Hide resolved
examples/due_date_probabilities/probability_estimation.py Outdated Show resolved Hide resolved
hamilton/dataflows/__init__.py Show resolved Hide resolved
@skrawcz skrawcz merged commit 3ce39a1 into main Aug 20, 2024
28 checks passed
@skrawcz skrawcz deleted the ruff_B_code branch August 20, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants