Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update optimize objfun #133

Merged
merged 11 commits into from
Feb 5, 2025
Merged

Update optimize objfun #133

merged 11 commits into from
Feb 5, 2025

Conversation

Tom-Szendrey
Copy link
Contributor

@Tom-Szendrey Tom-Szendrey commented Feb 3, 2025 •
edited
Loading

Description

  • Clean up typing so that this is slightly more understandable where and what these values are used for and coming from
  • Allow user to specify two obj functions when they have provided the option to optimize over new value and start time

Related and Required

DARPA-ASKEM/terarium#6368

TODO:
lots of testing.

@Tom-Szendrey Tom-Szendrey linked an issue Feb 3, 2025 that may be closed by this pull request
[TASK]: Missing a case in "Optimize" operator to handle divergent new-value and start-time optimization #132
Closed
@Tom-Szendrey Tom-Szendrey mentioned this pull request Feb 4, 2025
Merged
@Tom-Szendrey Tom-Szendrey marked this pull request as ready for review February 5, 2025 19:18
@Tom-Szendrey Tom-Szendrey requested a review from mwdchang February 5, 2025 19:28
@dgauldie dgauldie merged commit 6a155a8 into main Feb 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgauldie dgauldie dgauldie approved these changes

@liunelson liunelson Awaiting requested review from liunelson

@blanchco blanchco Awaiting requested review from blanchco

@mwdchang mwdchang Awaiting requested review from mwdchang

Assignees

@liunelson liunelson

@mwdchang mwdchang

@blanchco blanchco

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TASK]: Missing a case in "Optimize" operator to handle divergent new-value and start-time optimization
5 participants
@Tom-Szendrey @dgauldie @liunelson @mwdchang @blanchco