point features will save as rasters #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested with and Exited cleanly, no exceptions raised. f1 scores were |
robkooper
reviewed
May 6, 2024
src/pipeline_steps.py
Outdated
| io.saveGeoTiff(filepath, feature_mask, map_data.georef.crs, map_data.georef.transform) | ||
| if feature.type == MapUnitType.POLYGON: | ||
| if map_data.poly_segmentation_mask is None: | ||
| #pipeline_manager.log(logging.WARNING, f'Can\'t validate feature {feature.label}. No predicted segmentation mask present.') |
There was a problem hiding this comment.
You can use both types of quotes in this case.
Suggested change
| #pipeline_manager.log(logging.WARNING, f'Can\'t validate feature {feature.label}. No predicted segmentation mask present.') | |
| #pipeline_manager.log(logging.WARNING, f"Can't validate feature {feature.label}. No predicted segmentation mask present.") |
robkooper
approved these changes
May 6, 2024
src/pipeline_steps.py
Outdated
| feature_mask[map_data.poly_segmentation_mask == legend_index] = 1 | ||
| filepath = os.path.join(output_dir, sanitize_filename(f'{map_data.name}_{feature.label}.tif')) | ||
| io.saveGeoTiff(filepath, feature_mask, map_data.georef.crs, map_data.georef.transform) | ||
| pipeline_manager.log(logging.DEBUG, f'{map_data.name}, {feature.label} {feature.type}') |
There was a problem hiding this comment.
do we still need this line?
| filepath = os.path.join(output_dir, sanitize_filename(f'{map_data.name}_{feature.label}.tif')) | ||
| io.saveGeoTiff(filepath, feature_mask, map_data.georef.crs, map_data.georef.transform) | ||
| pipeline_manager.log(logging.DEBUG, f'{map_data.name}, {feature.label} {feature.type}') | ||
| if feature.type == MapUnitType.POINT: |
There was a problem hiding this comment.
looks like most of the code is the same would it make sense to just use:
Suggested change
| if feature.type == MapUnitType.POINT: | |
| if feature.type == MapUnitType.POINT or feature.type == MapUnitType.POLYGON: |
There was a problem hiding this comment.
There was a small difference between the two blocks. map_data.poly_segmentation_mask vs. map_data.point_segmentation_mask. But there was redundant code in them too. Take a look now, I've made some adjustments.
robkooper
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.