Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent starting task if captions are nil #33

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jayaquino
Copy link
Contributor

Media

image

Description

  • Prevent the task from being started if not needed (saw it clogging up instruments with it constantly firing).

Type of change

  • Feature (newly added functionality not yet in production)
  • Bug (fixing functionality not yet in production)
  • Patch (fixing functionality currently in production)
  • Clean or Refactor (updates to existing code that does not change functionality)

@JordanOsterberg
Copy link
Contributor

@jayaquino Have you verified that instruments no longer is populated with the entries from your screenshot? I could be misreading the table, but it appears the rows are coming from onPlayerTimeChanged(time:), not from any of the methods it calls into under the hood.

@jayaquino
Copy link
Contributor Author

@JordanOsterberg Yes they don't appear when the Task is not executed since it's contained in onPlayerTimeChanged(time:). This is on Swift Concurrency by the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants