Skip to content
This repository has been archived by the owner on Oct 10, 2019. It is now read-only.

Fixes some minor repo inconsistencies #3

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

dappiu
Copy link
Contributor

@dappiu dappiu commented Jul 25, 2019

  • Updates Zenroom submodule to the point where is supposed to be
  • Regenerate dist/ files and doc based on current code
  • Uses the correct ESLint preset for the code style used
  • Uses ESLint for linting, remove "standard" package
  • Upgrades dependencies and lock file maintenance

❤️

@codecov-io
Copy link

codecov-io commented Jul 25, 2019

Codecov Report

Merging #3 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #3   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          66     66           
=====================================
  Hits           66     66

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51e424a...8e08999. Read the comment docs.

@puria puria self-requested a review July 25, 2019 17:05
Copy link
Member

@puria puria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the .wasm .mem changed to the latest @decodeproject/zenroom commit? I use to have the last published version of the npm, but fine to have it updated and sync to the actual wrapper code... thanks ;)

@@ -77,6 +75,8 @@ var zenroom = function () {
* @example <caption>Example usage of `script()`</caption>
* // returns zenroom
* import zenroom from 'zenroom'
* // or without ES6 syntax
* // const zenroom = require('zenroom').default
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please update also the README.md?

Copy link
Contributor Author

@dappiu dappiu Jul 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .wasm and .js files are the output from Zenroom @ 34cc00c, the commit referred from the submodule, and emscripten

Actually, compiling from the master branch of Zenroom, the wasm produced won't pass the tests in which the script contains a reference to the global ECDH and spits out these messages:

[string "..."]:2: attempt to index a nil value (global 'ECDH')
[string "ZEN:begin(1)..."]:1: attempt to index a nil value (global 'ZEN')[!]

I'd ask @jaromil to give me a hint on how to address this problem

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it fixed now?

Copy link
Member

@puria puria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uuuuuuh I love standard actually... it hurts you? Or there is a rationale?

Copy link
Member

@puria puria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💟

Copy link
Member

@puria puria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@puria puria self-requested a review July 25, 2019 17:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants