Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed the Print button partial #523

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Removed the Print button partial #523

merged 1 commit into from
Apr 17, 2024

Conversation

DrizzlyOwl
Copy link
Collaborator

@DrizzlyOwl DrizzlyOwl commented Feb 5, 2024 •
edited
Loading

  • the partial was never used and was written 2y ago
  • the assets that were being loaded also referenced missing fonts which caused 4x 404s on every page load
  • there was a lot of duplicated CSS that clashed with the gov.uk frontend

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Steps to test this PR

  1. Build the app using this PR as the base
  2. Load the web page in your browser
  3. Ensure CSS/Fonts etc are working as expected

@DrizzlyOwl DrizzlyOwl force-pushed the remove-broken-print-partial branch from fb2c64c to 9e3e732 Compare February 6, 2024 17:59
@DrizzlyOwl DrizzlyOwl force-pushed the remove-broken-print-partial branch 3 times, most recently from 0ceb58f to ea631cb Compare February 13, 2024 13:34
@DrizzlyOwl DrizzlyOwl added the help wanted Extra attention is needed label Feb 16, 2024
@DrizzlyOwl DrizzlyOwl force-pushed the remove-broken-print-partial branch from ea631cb to f84cf48 Compare February 21, 2024 11:35
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@DrizzlyOwl DrizzlyOwl force-pushed the remove-broken-print-partial branch from f84cf48 to 9361714 Compare April 11, 2024 13:09
@DrizzlyOwl
Removed the Print button partial
11e3b05 
* the partial was never used and was written 2y ago
* the assets that were being loaded also referenced missing fonts which caused 4x 404s on every page load
* there was a lot of duplicated CSS that clashed with the gov.uk frontend
@DrizzlyOwl DrizzlyOwl force-pushed the remove-broken-print-partial branch from 2057955 to 11e3b05 Compare April 17, 2024 16:01
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@DrizzlyOwl DrizzlyOwl merged commit b07c8c3 into master Apr 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwarms nwarms nwarms approved these changes

@cshnimble cshnimble cshnimble approved these changes

@paullocknimble paullocknimble Awaiting requested review from paullocknimble

Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DrizzlyOwl @cshnimble @nwarms