Update app/services/can_recruit_with_pending_conditions.rb

Co-authored-by: Carlos Martinez <[email protected]>
DFE-Digital · Oct 12, 2023 · 1be3d83 · 1be3d83
1 parent 14dcf06
commit 1be3d83
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/app/services/can_recruit_with_pending_conditions.rb b/app/services/can_recruit_with_pending_conditions.rb
@@ -29,9 +29,8 @@ def offer_has_pending_ske_conditions?
   end
 
   def offer_has_no_unmet_non_ske_conditions?
-    application_choice.offer.conditions.none? do |condition|
-      !condition.is_a?(SkeCondition) && !condition.met?
-    end
+    non_ske_conditions = application_choice.offer.conditions - application_choice.offer.ske_conditions
+    non_ske_conditions.all?(&:met?)
   end
 
   def provider_is_scitt?