bug fix

DFE-Digital · Dec 19, 2024 · 46bf163 · 46bf163
1 parent c579ed1
commit 46bf163
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/app/forms/candidate_interface/withdrawal_reasons/secondary_reasons_form.rb b/app/forms/candidate_interface/withdrawal_reasons/secondary_reasons_form.rb
@@ -36,7 +36,7 @@ def self.build_from_application_choice(primary_reason, application_choice)
         end
 
         withdrawal_reasons.each do |withdrawal_reason|
-          if withdrawal_reason.reason.include?('personal-circumstances-have-changed.')
+          if withdrawal_reason.reason.include?("#{PERSONAL_CIRCUMSTANCES_KEY}.")
             personal_circumstances_reasons << (withdrawal_reason.reason.split('.') - [primary_reason]).join('.')
             personal_circumstances_reasons_comment = withdrawal_reason.comment if withdrawal_reason.comment.present?
           else
@@ -61,7 +61,7 @@ def create!
         @application_choice.draft_withdrawal_reasons.destroy_all
 
         # Then create from valid form attributes
-        [secondary_reasons, personal_circumstances_reasons].flatten.each do |reason|
+        [secondary_reasons, personal_circumstances_reasons].flatten.compact.each do |reason|
           next if reason == PERSONAL_CIRCUMSTANCES_KEY
 
           other_comment = if reason == 'other'