Fix Rubocop issues

DFE-Digital · Oct 17, 2023 · b6460a2 · b6460a2
1 parent 896b040
commit b6460a2
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 12 deletions.
diff --git a/app/models/application_choice.rb b/app/models/application_choice.rb
@@ -265,14 +265,6 @@ def supplementary_statuses
     end
   end
 
-  def supplementary_statuses
-    [].tap do |supplementary_statuses|
-      if recruited? && RecruitedWithPendingConditions.new(application_choice: self).call
-        supplementary_statuses << :ske_pending_conditions
-      end
-    end
-  end
-
 private
 
   def set_initial_status

diff --git a/spec/mailers/candidate_mailer_spec.rb b/spec/mailers/candidate_mailer_spec.rb
@@ -436,7 +436,7 @@
     end
 
     before do
-      FeatureFlag.activate(:recruit_with_pending_conditions) 
+      FeatureFlag.activate(:recruit_with_pending_conditions)
       application_choices.first.provider.provider_type = :scitt
       application_choices.first.course.start_date = 2.months.from_now
     end

diff --git a/spec/mailers/previews/candidate_mailer_preview.rb b/spec/mailers/previews/candidate_mailer_preview.rb
@@ -813,12 +813,12 @@ def conditions_met
 
   def conditions_met_with_pending_ske_conditions
     FeatureFlag.activate(:recruit_with_pending_conditions)
-    application_choice = application_choice_with_offer.tap do |choice|
+    application_choice = application_choice_pending_conditions.tap do |choice|
       choice.offer.conditions.first.status = :met
       choice.offer.ske_conditions = [FactoryBot.build_stubbed(:ske_condition, status: :pending)]
       choice.status = :recruited
-      choice.provider.provider_type = :scitt
-      choice.course.start_date = 1.month.from_now
+      choice.current_course_option.provider.provider_type = :scitt
+      choice.current_course_option.course.start_date = 1.month.from_now
     end
 
     CandidateMailer.conditions_met(application_choice)