add dependent destroy to draft withdrawal reasons

DFE-Digital · Jan 2, 2025 · bc306cb · bc306cb
1 parent e472fda
commit bc306cb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/app/models/application_choice.rb b/app/models/application_choice.rb
@@ -27,7 +27,7 @@ class ApplicationChoice < ApplicationRecord
   has_many :notes, dependent: :destroy
   has_many :interviews, dependent: :destroy
   has_many :withdrawal_reasons, dependent: :destroy
-  has_many :draft_withdrawal_reasons, -> { draft }, class_name: 'WithdrawalReason'
+  has_many :draft_withdrawal_reasons, -> { draft }, class_name: 'WithdrawalReason', dependent: :destroy
 
   has_many :work_experiences, as: :experienceable, class_name: 'ApplicationWorkExperience'
   has_many :volunteering_experiences, as: :experienceable, class_name: 'ApplicationVolunteeringExperience'

diff --git a/spec/models/application_choice_spec.rb b/spec/models/application_choice_spec.rb
@@ -4,7 +4,8 @@
   it { is_expected.to have_many(:work_experiences).class_name('ApplicationWorkExperience') }
   it { is_expected.to have_many(:volunteering_experiences).class_name('ApplicationVolunteeringExperience') }
   it { is_expected.to have_many(:work_history_breaks).class_name('ApplicationWorkHistoryBreak') }
-  it { is_expected.to have_many(:withdrawal_reasons) }
+  it { is_expected.to have_many(:withdrawal_reasons).dependent(:destroy) }
+  it { is_expected.to have_many(:draft_withdrawal_reasons).dependent(:destroy) }
 
   describe 'auditing', :with_audited do
     it 'creates audit entries' do