Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike AB testing #10131

Closed
wants to merge 1 commit into from
Closed

Spike AB testing #10131

wants to merge 1 commit into from

Conversation

elceebee
Copy link
Contributor

@elceebee elceebee commented Dec 2, 2024

Context

Changes proposed in this pull request

Guidance to review

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Required environment variables have been updated added to the Azure KeyVault
  • Inform data insights team due to database changes
  • Make sure all information from the Trello card is in here
  • Rebased main
  • Cleaned commit history
  • Tested by running locally
  • Add PR link to Trello card

@elceebee
Copy link
Contributor Author

elceebee commented Dec 2, 2024

AB testing spike

@elceebee elceebee added the deploy_v2 Deploy the review app to AKS label Dec 2, 2024
@github-actions github-actions bot temporarily deployed to review_aks-10131 December 2, 2024 17:09 Destroyed
@elceebee elceebee force-pushed the 490-ab-testing-spike branch from f4d8b09 to b2b6bba Compare December 3, 2024 08:35
@github-actions github-actions bot temporarily deployed to review_aks-10131 December 3, 2024 08:40 Destroyed
@github-actions github-actions bot temporarily deployed to review_aks-10131 December 3, 2024 08:54 Destroyed
@elceebee elceebee force-pushed the 490-ab-testing-spike branch from b2b6bba to 22ec743 Compare December 3, 2024 15:58
@github-actions github-actions bot temporarily deployed to review_aks-10131 December 3, 2024 16:06 Destroyed
@elceebee
Copy link
Contributor Author

elceebee commented Dec 4, 2024

This can serve as a example for when we want to implement this gem, but not adding now as no specific use case exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy_v2 Deploy the review app to AKS DO NOT MERGE DO NOT REVIEW
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant