-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
One login integration migrations #10144
Conversation
a32c93b
to
7567dcf
Compare
2dd5311
to
4874632
Compare
81aa5d3
to
e5a5596
Compare
e5a5596
to
1221503
Compare
1221503
to
8d32009
Compare
8d32009
to
6f7d451
Compare
6f7d451
to
86317ee
Compare
e472950
to
86317ee
Compare
86317ee
to
469743a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should split the migration, schema and analytics files into another PR which gets deployed first. Even though we're not using the code that relies on the migration in this instance, it's good practice.
469743a
to
54f920a
Compare
These are all the migrations we need for our one login integration, to allow a candidate to login or recover their account.
54f920a
to
80e7da2
Compare
I don't think we can split models from migrations. DfE analytics will look for models that you created in migrations. As long as the models being created are not called by views/controllers/apis/jobs we should be fine |
Context
We want to allow our candidates to login into apply with one login. We also want to allow them to recover their account if their one login email is different from the candidate's email.
These are all the migrations we need for our one login integration, to allow a candidate to login or recover their account.
This is based on the one login spike
Changes proposed in this pull request
We need to allow the user to reclaim their account with any code valid in the last 1 hour for example. That's why
AccountRecoveryRequest
has_manyAccountRecoveryRequestCodes
Guidance to review
Does it make sense?
Things to check