-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
One login auth #10160
Merged
Merged
One login auth #10160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CatalinVoineag
had a problem deploying
to
review_aks
December 10, 2024 15:01 — with
GitHub Actions
Failure
CatalinVoineag
had a problem deploying
to
review_aks
December 10, 2024 16:13 — with
GitHub Actions
Failure
CatalinVoineag
had a problem deploying
to
review_aks
December 10, 2024 16:59 — with
GitHub Actions
Failure
CatalinVoineag
had a problem deploying
to
review_aks
December 10, 2024 17:02 — with
GitHub Actions
Failure
CatalinVoineag
had a problem deploying
to
review_aks
December 10, 2024 17:08 — with
GitHub Actions
Failure
CatalinVoineag
had a problem deploying
to
review_aks
December 10, 2024 17:11 — with
GitHub Actions
Failure
CatalinVoineag
had a problem deploying
to
review_aks
December 10, 2024 17:14 — with
GitHub Actions
Failure
CatalinVoineag
had a problem deploying
to
review_aks
December 11, 2024 09:08 — with
GitHub Actions
Failure
CatalinVoineag
had a problem deploying
to
review_aks
December 11, 2024 09:45 — with
GitHub Actions
Failure
CatalinVoineag
had a problem deploying
to
review_aks
December 11, 2024 09:49 — with
GitHub Actions
Failure
CatalinVoineag
had a problem deploying
to
review_aks
December 11, 2024 09:54 — with
GitHub Actions
Failure
CatalinVoineag
force-pushed
the
cv/one-login-auth
branch
from
December 11, 2024 10:01
a9cb3b0
to
fbac42b
Compare
CatalinVoineag
had a problem deploying
to
review_aks
December 11, 2024 10:01 — with
GitHub Actions
Failure
CatalinVoineag
force-pushed
the
cv/one-login-auth
branch
from
December 11, 2024 10:40
fbac42b
to
f6afd66
Compare
CatalinVoineag
had a problem deploying
to
review_aks
December 11, 2024 10:40 — with
GitHub Actions
Failure
CatalinVoineag
temporarily deployed
to
review_aks
December 11, 2024 10:47 — with
GitHub Actions
Inactive
CatalinVoineag
force-pushed
the
cv/one-login-auth
branch
from
December 11, 2024 10:58
b4a8b0b
to
605271c
Compare
CatalinVoineag
temporarily deployed
to
review_aks
December 11, 2024 11:03 — with
GitHub Actions
Inactive
CatalinVoineag
had a problem deploying
to
review_aks
December 11, 2024 11:08 — with
GitHub Actions
Failure
CatalinVoineag
force-pushed
the
cv/one-login-auth
branch
from
December 11, 2024 11:17
605271c
to
81853bb
Compare
CatalinVoineag
temporarily deployed
to
review_aks
December 11, 2024 11:18 — with
GitHub Actions
Inactive
CatalinVoineag
temporarily deployed
to
review_aks
December 11, 2024 11:23 — with
GitHub Actions
Inactive
CatalinVoineag
temporarily deployed
to
review_aks
December 12, 2024 11:45 — with
GitHub Actions
Inactive
CatalinVoineag
temporarily deployed
to
review_aks
December 18, 2024 11:22 — with
GitHub Actions
Inactive
CatalinVoineag
temporarily deployed
to
review_aks
December 18, 2024 11:25 — with
GitHub Actions
Inactive
CatalinVoineag
had a problem deploying
to
review_aks
December 18, 2024 11:27 — with
GitHub Actions
Failure
CatalinVoineag
temporarily deployed
to
review_aks
December 18, 2024 11:42 — with
GitHub Actions
Inactive
CatalinVoineag
temporarily deployed
to
review_aks
December 18, 2024 11:46 — with
GitHub Actions
Inactive
dcyoung-dev
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one - I've highlighted a few name changes but other than that this is good to go 👌
app/views/candidate_interface/start_page/create_account_or_sign_in.html.erb
Outdated
Show resolved
Hide resolved
CatalinVoineag
temporarily deployed
to
review_aks
December 18, 2024 13:21 — with
GitHub Actions
Inactive
CatalinVoineag
temporarily deployed
to
review_aks
December 18, 2024 13:28 — with
GitHub Actions
Inactive
CatalinVoineag
force-pushed
the
cv/one-login-auth
branch
from
December 18, 2024 13:41
f72f01a
to
2a7e262
Compare
CatalinVoineag
temporarily deployed
to
review_aks
December 18, 2024 13:41 — with
GitHub Actions
Inactive
CatalinVoineag
temporarily deployed
to
review_aks
December 18, 2024 13:45 — with
GitHub Actions
Inactive
CatalinVoineag
had a problem deploying
to
sandbox_aks
December 18, 2024 13:55 — with
GitHub Actions
Failure
We want to move our candidates to use one login when sigin up/in to our service. This commit adds the basic implementation for users to login or create a candidate account in apply using one login. It also adds a bypass for review and local development
The smoke test needs to be smarter now that we will introduce one login. We need to check if one login is enabled but we don't have control over the host app, as we use a remote host, when we deploy to review we use the review app host, same with deploying to other envs. This commit tries to make the smoke test smarted and tests one login or magic link depending on what is the sign up method on the host.
CatalinVoineag
force-pushed
the
cv/one-login-auth
branch
from
December 18, 2024 13:58
2a7e262
to
84827b9
Compare
CatalinVoineag
temporarily deployed
to
review_aks
December 18, 2024 13:58 — with
GitHub Actions
Inactive
CatalinVoineag
temporarily deployed
to
review_aks
December 18, 2024 14:04 — with
GitHub Actions
Inactive
CatalinVoineag
had a problem deploying
to
sandbox_aks
December 18, 2024 14:09 — with
GitHub Actions
Failure
CatalinVoineag
temporarily deployed
to
review_aks
December 18, 2024 14:14 — with
GitHub Actions
Inactive
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We want to move our candidates to use one login when sigin up/in to our
service.
This PR adds the basic implementation for users to log in or create
a candidate account in apply using one login. It also has a bypass for localhost and review apps.
Next steps:
Changes proposed in this pull request
Changes to the smoke test e4fbcba
Guidance to review
For bypass
Go on review app and log in as a candidate
Put anything in the uid column, a new candidate with one login will be created
Email would be
[email protected]
Log out
Use the same uid, you should be logged in as the same candidate now.
For normal flow
Go on an https://qa.apply-for-teacher-training.service.gov.uk/candidate/account
Click continue
Input your one login account, you might already have one, if not create one.
You should be redirected back to qa
kazam_proo7lg1.movie.mp4
Things to check