[512] Expose inactive on ApplicationAttribute on the Vendor API (V1.6pre)
#10189
+82
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avinhurry
force-pushed
the
512-inactive-attribute-in-vendor-api
branch
from
be7e868 to
6a54267
Compare
avinhurry
had a problem deploying
to
review_aks
GitHub Actions
Failure
avinhurry
force-pushed
the
512-inactive-attribute-in-vendor-api
branch
from
6a54267 to
9b7019c
Compare
dcyoung-dev
requested changes
Dec 18, 2024
app/presenters/vendor_api/application_presenter/add_inactive_status.rb
Outdated
Show resolved
Hide resolved
@dcyoung-dev see my comment here, this is not a breaking change. |
avinhurry
force-pushed
the
512-inactive-attribute-in-vendor-api
branch
from
b022f27 to
678ce46
Compare
avinhurry
force-pushed
the
512-inactive-attribute-in-vendor-api
branch
from
678ce46 to
e1a4fb4
Compare
avinhurry
force-pushed
the
512-inactive-attribute-in-vendor-api
branch
from
e1a4fb4 to
8916914
Compare
dcyoung-dev
approved these changes
Dec 18, 2024
avinhurry
force-pushed
the
512-inactive-attribute-in-vendor-api
branch
from
8916914 to
0b86d46
Compare
avinhurry
force-pushed
the
512-inactive-attribute-in-vendor-api
branch
from
0b86d46 to
889f7af
Compare
avinhurry
force-pushed
the
512-inactive-attribute-in-vendor-api
branch
from
889f7af to
0329959
Compare
You have one or more flakey tests on this branch! ❄️ ❄️ ❄️Failed 1 out of 3 times at ./spec/workers/detect_invariants_daily_check_spec.rb:148: |
avinhurry
had a problem deploying
to
review_aks
GitHub Actions
Failure
avinhurry
changed the title
inactive on status via ApplicationAttribute on the Vendor API (V1.6pre)inactive on ApplicationAttribute on the Vendor API (V1.6pre)
avinhurry
had a problem deploying
to
review_aks
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We developing the next version of the API (
1.6).A draft version (
1.6pre) will be passed by the vendors as a way to test the changes on sandbox before we officially release the new version.Once the vendors have tested and are happy, we will make the release official, at which point we will update the API release notes and official documentation.
Changes proposed in this pull request
Expose inactive to theApplicationAttributestatusesThe decision was taken to add a new
inactivefield onApplicationAttributeto expose the inactive status. See this comment.Guidance to review
I've set application choice
16toinactiveon the review app.Use the Vendor API on the review app or locally. In particular, check the
statusonApplicationAttributefor an application choice which has a status ofinactive.Repeat for other statuses and ensure the response accurately reflects the database.
Alternatively you could inspect the
MultipleApplicationsResponseon the draft API release document i've linked below.Review the draft release documentation.