Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect to sign_in page for magic link pages if one-login enabled #10193

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

CatalinVoineag
Copy link
Contributor

@CatalinVoineag CatalinVoineag commented Dec 18, 2024

Context

When the one login feature flag is activated, we should not let the user to go to any magic links urls

Changes proposed in this pull request

before check in magic links controllers

Guidance to review

Go on review app and try these URLs, you should be redirected back to sign in page

/candidate/sign-up
/candidate/sign-in

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist, if included inform data insights team of the changes
  • If this code adds a column that may include PII, the sanitise.sql script and 0025-protecting-personal-data-in-production-dump.md ADR have been updated.
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Attach the PR to the Trello card

@CatalinVoineag CatalinVoineag self-assigned this Dec 18, 2024
@CatalinVoineag CatalinVoineag added the deploy_v2 Deploy the review app to AKS label Dec 18, 2024
@CatalinVoineag
Copy link
Contributor Author

@github-actions github-actions bot temporarily deployed to review_aks-10193 December 18, 2024 15:54 Destroyed
@CatalinVoineag CatalinVoineag force-pushed the cv/block-magic-link-requests branch from 2b3c9c7 to 85478e6 Compare December 18, 2024 16:28
@github-actions github-actions bot temporarily deployed to review_aks-10193 December 18, 2024 16:33 Destroyed
@github-actions github-actions bot temporarily deployed to review_aks-10193 December 18, 2024 16:46 Destroyed
@CatalinVoineag CatalinVoineag marked this pull request as ready for review December 18, 2024 16:56
@CatalinVoineag CatalinVoineag requested a review from a team December 18, 2024 17:08
Copy link
Contributor

@elceebee elceebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up! I've tested on the review app and it works as expected

@CatalinVoineag CatalinVoineag force-pushed the cv/block-magic-link-requests branch from 85478e6 to 57c7ab3 Compare January 2, 2025 09:46
@github-actions github-actions bot temporarily deployed to review_aks-10193 January 2, 2025 09:51 Destroyed
@CatalinVoineag CatalinVoineag merged commit d92c2e1 into main Jan 2, 2025
23 checks passed
@CatalinVoineag CatalinVoineag deleted the cv/block-magic-link-requests branch January 2, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy_v2 Deploy the review app to AKS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants