-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redirect to sign_in page for magic link pages if one-login enabled #10193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CatalinVoineag
temporarily deployed
to
review_aks
December 18, 2024 15:36 — with
GitHub Actions
Inactive
CatalinVoineag
temporarily deployed
to
review_aks
December 18, 2024 15:50 — with
GitHub Actions
Inactive
CatalinVoineag
had a problem deploying
to
review_aks
December 18, 2024 15:54 — with
GitHub Actions
Failure
CatalinVoineag
force-pushed
the
cv/block-magic-link-requests
branch
from
December 18, 2024 16:28
2b3c9c7
to
85478e6
Compare
CatalinVoineag
temporarily deployed
to
review_aks
December 18, 2024 16:28 — with
GitHub Actions
Inactive
CatalinVoineag
had a problem deploying
to
review_aks
December 18, 2024 16:33 — with
GitHub Actions
Failure
CatalinVoineag
temporarily deployed
to
review_aks
December 18, 2024 16:46 — with
GitHub Actions
Inactive
avinhurry
approved these changes
Dec 19, 2024
elceebee
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning this up! I've tested on the review app and it works as expected
CatalinVoineag
force-pushed
the
cv/block-magic-link-requests
branch
from
January 2, 2025 09:46
85478e6
to
57c7ab3
Compare
CatalinVoineag
temporarily deployed
to
review_aks
January 2, 2025 09:47 — with
GitHub Actions
Inactive
CatalinVoineag
temporarily deployed
to
review_aks
January 2, 2025 09:51 — with
GitHub Actions
Inactive
CatalinVoineag
temporarily deployed
to
review_aks
January 2, 2025 10:01 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When the one login feature flag is activated, we should not let the user to go to any magic links urls
Changes proposed in this pull request
before check in magic links controllers
Guidance to review
Go on review app and try these URLs, you should be redirected back to sign in page
Things to check